Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve benchmark setup, consistently rely on publishConfig #1648

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

wycats
Copy link
Contributor

@wycats wycats commented Nov 3, 2024

This PR has two related changes:

  1. Clean up and document recent changes in the benchmark script. One of these changes is replacing ad-hoc rewrites of package.json files with a firm reliance on the publishConfig field, which should be reliable (since that's what we use when actually publishing).
  2. Update all of the package.json files for published packages to have consistent publishConfig fields. This change also removed a bunch of historical cruft from the package.json files, which helped us to support environments during the ecosystem transition to package.json exports fields.

@wycats wycats added the perf label Nov 3, 2024
This commit has two related changes:

1. Clean up and document recent changes in the benchmark script. One of
   these changes is replacing ad-hoc rewrites of `package.json` files
   with a firm reliance on the `publishConfig` field, which should be
   reliable (since that's what we use when actually publishing).
2. Update all of the `package.json` files for published packages to have
   consistent `publishConfig` fields. This change also removed a bunch
   of historical cruft from the `package.json` files, which helped us
   to support environments during the ecosystem transition to
   package.json `exports` fields.
@wycats wycats force-pushed the infra/improve-bench-setup-pt2 branch from f60a21c to dde2390 Compare November 3, 2024 22:04
@wycats wycats added perf and removed perf labels Nov 3, 2024
@wycats wycats merged commit 57e59c4 into main Nov 3, 2024
7 of 10 checks passed
@wycats wycats deleted the infra/improve-bench-setup-pt2 branch November 3, 2024 22:34
@github-actions github-actions bot mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants